PTAL
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java File user/src/com/google/gwt/dom/client/Document.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode18 user/src/com/google/gwt/dom/client/Document.java:18: import static com.google.gwt.dom.client.BrowserEvents.*; We have an auto-importer setting against it. Fixed here and in ClickableTextCell. On 2011/09/19 14:26:41, jlabanca wrote:
Do we have a rule against importing .*?
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode571 user/src/com/google/gwt/dom/client/Document.java:571: @SuppressWarnings("deprecation") Eclipse seems to think so. But it also seems not to notice the @SuppressWarnings and keep nagging. Reverted. On 2011/09/19 14:26:41, jlabanca wrote:
Do you need to suppress deprecation on a deprecated method?
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java File user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java#newcode162 user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java:162: if (BrowserEvents.FOCUSIN.equals(type)) { I think Thomas wins here. On 2011/09/19 14:26:41, jlabanca wrote:
FOCUSIN is IE specific. I would leave the string in this case, or
create a
static private String in this impl class.
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java#newcode175 user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java:175: } else if ("focusout".equals(type)) { And adding this to BrowserEvents http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode57 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:57: if (evt.getType().equals(BrowserEvents.MOUSEOUT)) { Thanks! On 2011/09/19 14:26:41, jlabanca wrote:
MOUSEOUT/MOUSEOVER
http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
