LGTM

Minor nit, but no need to upload another patch.  I'll switch to
onAttach/onDetach before submitting.


http://gwt-code-reviews.appspot.com/1615804/diff/1/user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/1615804/diff/1/user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java#newcode201
user/src/com/google/gwt/user/client/ui/DeckLayoutPanel.java:201: public
void onLoad() {
These should probably go in onAttach/onDetach instead of
onLoad/onUnload.  Users may not call super.onLoad/onUnload, but if you
override onAttach/onDetach you must call the super methods.

http://gwt-code-reviews.appspot.com/1615804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to