You might want to change DockLayoutPanel ...

Thanks for the review guys. I'm ambivalent about onLoad vs. onAttach,
although as Thomas said I was just following suit of the other panels.

IMO, users *should* call super.onLoad unless they're directly
extending Widget.

Yeah, I agree; I was tempted to add "super.onLoad/onUnload" calls
because I think even if the parent methods are no-ops its a good habit
to get in to (and to have users reading the code see/think about) unless
you really are replacing the super implementation instead of just
augmenting it.

But I'm fine with whatever you end up committing, John. Thanks!


http://gwt-code-reviews.appspot.com/1615804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to