Adding the ".keys." and ".values." disambiguation was much much simpler
than I'd thought thanks to the prefix variable being passed down so can
have the codereview updated with this change very shortly.
On 4 June 2012 13:07, James Horsley <james.hors...@gmail.com> wrote:
> I finally managed to get time to look at this. I added tests to answer to
> Alexis's original question and my current patch out for review would not
> work with his supplied case. Luckily, it was a fairly easy change to
> addPathsToResolution to have it add the child resolutions without handling
> the edge case Thomas pointed out.
>
> I really Thomas's ".keys." and ".values." suggestion for disambiguation of
> a common property name between the key and value types so, unless anyone
> prefers "theMap.e" pulling in both the key's E's and values's E's,
> I'll take a stab at that change.
>
> Let me know if there're any other suggestions.
>
> Cheers,
> James
>
> On 25 May 2012 22:06, Thomas Broyer <t.bro...@gmail.com> wrote:
>
>> AutoBean has no equivalent to these "partial loading"; just like a POJO
>> has no notion of lazy loading, compared to JPA entities.
>> Le 25 mai 2012 21:06, "James Horsley" <james.hors...@gmail.com> a écrit :
>>
>> I read Alexis's email too hastily and hadn't noted he was asking about
>>> nested complex types. I'll add some tests to see how it behaves. I'll be
>>> interested to dig into what AutoBean's behaviour is here as that's what I
>>> based on, mimicked, and leveraged for this patch.
>>>
>>> On 25 May 2012 19:38, <t.bro...@gmail.com> wrote:
>>>
>>>> On 2012/05/25 17:09:32, james.horsley wrote:
>>>>
>>>>> I added tests for complex keys and complex values which're passing so
>>>>>
>>>> it
>>>>
>>>>> should do yes.
>>>>>
>>>>
>>>> I don't see any change to addPathsToResolution...
>>>> Also, how would it work? Say I have a Map<A,B>, A has a reference "c" to
>>>> a proxy C, and B has a reference "d" to a proxy D. What should I pass to
>>>> Request#with() to get the Ds of B without the Cs of A? with("theMap.d")
>>>> ? Now what if A and B both have a property "e" referencing a proxy E, I
>>>> want B's Es but not A's Es, with("theMap.e") wouldn't work here.
>>>> I think maybe there should be special subproperties "keys" and "values",
>>>> so one can say: with("myMap.keys.c", "myMap.values.d", "myMap.values.e")
>>>> to get A's Cs, and B's Ds and Es (without A's Es!)
>>>>
>>>>
>>>>
>>>> http://codereview.appspot.com/**6132056/<http://codereview.appspot.com/6132056/>
>>>>
>>>
>>>
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
