Goktug Gokdogan has posted comments on this change.
Change subject: Stop using prefixed API's in AnimationScheduler by default.
Firefox and Safari will use the Timer-based implementation. For Chrome we
can use requestAnimationFrame because it's unprefixed starting in Chrome 24.
......................................................................
Patch Set 1:
(3 comments)
I think this is a good idea.
Some comments are inlined.
....................................................
Commit Message
Line 14: once it's unprefixed. I attempted to avoid depending on any
details of the
also Firefox shares the same deferred binding in the xml, that means it
will also pickup once it is unprefixed.
....................................................
File user/src/com/google/gwt/animation/Animation.gwt.xml
Line 27: <replace-with
class="com.google.gwt.animation.client.AnimationSchedulerImplTimer">
why is native not the default? If browser supports unprefixed
requestAnimationFrame, I think we can safely use it; especially as we are
not relying on any parameters or return values.
Line 41: <!-- Disabled by default because it uses a prefixed API. -->
Perhaps we can introduce a "use-prefixed" property (false by default) to be
used in this kind of situations?
--
To view, visit https://gwt-review.googlesource.com/1780
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3011dceab489871a5864eed1ece47ec850d82425
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
