Brian Slesinsky has posted comments on this change.

Change subject: Make AnimationScheduler configurable and change defaults.
......................................................................


Patch Set 1:

(4 comments)

....................................................
File user/src/com/google/gwt/animation/Animation.gwt.xml
Line 27: <replace-with class="com.google.gwt.animation.client.AnimationSchedulerImplTimer"> I have Windows 7 so it's not so easy to test. Can someone try it on Windows 8? (And it seems like it's another patch.)


Line 27: <replace-with class="com.google.gwt.animation.client.AnimationSchedulerImplTimer">
I think we shouldn't use it without testing it?


Line 41:   <!-- Disabled by default because it uses a prefixed API. -->
See the new patch. Not sure about the defaults yet.


....................................................
File user/src/com/google/gwt/animation/client/AnimationSchedulerImplNative.java Line 60: * create a JavaScriptObject and add an expando named "cancelled" to indicate
Done


--
To view, visit https://gwt-review.googlesource.com/1780
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3011dceab489871a5864eed1ece47ec850d82425
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to