James Nelson has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
......................................................................
Patch Set 2:
(2 comments)
Marked points in code that may need to change / be checked against reitveld
copy. If John wants to overwrite owner with a new commit, he'll know why I
made the given changes.
....................................................
File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
Line 238: // as elemental Browser class loads many unused classes in
dev mode
This code comment addresses a comment on rietveld about the arbitrarily
large size. We may want to trim this down.
Line 246: cls, cls != Class.class);
This is the mentioned small tweak; the boolean value sent to
findMostDerivedMembers is what determines if constructors are to be
indexed. The normal exception handling doesn't catch the SecurityException
which happens if dev mode tries to set Class<init>() to accessible.
--
To view, visit https://gwt-review.googlesource.com/2210
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: John Ahlroos <j...@vaadin.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
