James Nelson has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
......................................................................
Patch Set 3:
Yes, this patch will not be able to fix the actual underlying issue; the
best it could do is mask the problem with & 0xffff, which would just lead
to indeterminism.
if (dispId & 0xfff > 0) throw new Error("You've got a lot of JSOs there,
shouldn't you be using super dev mode?");
The part that is actually breaking (in class Jsni) is actually just looking
for the classId; it gets the merged int and then fails when extracting the
clsId. A check for jsos / JavaScriptObject$ beforehand could bypass the
overflow. Thing is, it failed on PotentialElement, and not
JavaScriptObject$. PotentialElement's DispatchClassInfo was filled with
methods from JSO$ (80,000+ on skeleton project).
--
To view, visit https://gwt-review.googlesource.com/2210
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: John Ahlroos <j...@vaadin.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
