Thomas Broyer has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
......................................................................
Patch Set 2:
(3 comments)
....................................................
File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 86: public static StackTraceDeobfuscator fromURL(final URL urlPath) {
AFAICT, we've been trying to move towards 'Url' lately; 'URL' are older
APIs.
Line 89: return new URL(urlPath, fileName).openStream();
If you ask me, we should just remove the FileNotFoundException from the
javadoc, as it's depend on how you load the data (which is not necessarily
a "file"); and keep the MissingResourceException from above (assuming we're
using it correctly, the javadoc is a bit light…)
Line 338: * @param fileName name of the symbol or source map file (not
including a slash)
What does "not including a slash" means?
--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
