Goktug Gokdogan has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
......................................................................
Patch Set 2:
(4 comments)
....................................................
File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 65: throw new MissingResourceException("Missing resource: "
+ filePath, null, filePath);
(Decided not to go with FileNotFoundException.)
Line 86: public static StackTraceDeobfuscator fromURL(final URL urlPath) {
I remember 'Url' was the suggested one but URL class itself was all upper
case so I was in between. I'm changing it to fromUrl.
Line 89: return new URL(urlPath, fileName).openStream();
Hmm, I thought MissingResourceException was an IOException. I will change
that.
I also agree the consistently throwing FileNotFoundException is going to be
difficult. (Similarly, URL.openStream doesn't classify the IOException
further.) Removing FileNotFoundException from javadoc.
Line 338: * @param fileName name of the symbol or source map file (not
including a slash)
I was hesitated to add that. It looks like, it will just cause confusion.
It is named as fileName instead of filePath anyway. Removing the extra info.
--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
