Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
& StacktraceDeobfuscator.
......................................................................
Patch Set 1:
(5 comments)
....................................................
File user/src/com/google/gwt/junit/JUnitMessageQueue.java
Line 468: Class<?> thrown = getExceptionClass(result.getException());
Done
....................................................
File user/src/com/google/gwt/junit/JUnitShell.java
Line 1231: SerializableThrowable thrown = result.getException();
I simplified some pieces but I tried not to move too much logic into
JUnitResult.
....................................................
File user/src/com/google/gwt/junit/server/JUnitHostImpl.java
Line 171: System.err.println("Cannot deobfucsate stack trace:");
Done
....................................................
File user/test/com/google/gwt/junit/client/ExpectedFailure.java
Line 37: Class<? extends ExceptionAsserter> withAsserter() default
ExceptionAsserter.class;
Making DefaultExceptionAsserter @GwtIncompatible didn't work - caused
compilation error. But I stated using GwtIncompatible.
....................................................
File user/test/com/google/gwt/junit/client/GWTTestCaseStackTraceTest.java
Line 38: AssertionFailedError exception = new
AssertionFailedError("stack_trace_msg");
Done
--
To view, visit https://gwt-review.googlesource.com/2290
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
