Hello Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

    https://gwt-review.googlesource.com/2290

to look at the new patch set (#3).

Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable & StacktraceDeobfuscator.
......................................................................

Refactors c.g.gwt.junit to use common SerializableThrowable & StacktraceDeobfuscator.

- Gets rid of duplicate code in junit for deobfuscation of stack traces
- Improves the messaging of unserializable exceptions
- Minor improvements to the reporting of test infra failures

Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Review-Link: https://gwt-review.googlesource.com/#/c/2290/
---
M user/src/com/google/gwt/core/client/JavaScriptException.java
M user/src/com/google/gwt/junit/JUnitMessageQueue.java
M user/src/com/google/gwt/junit/JUnitShell.java
D user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java
M user/src/com/google/gwt/junit/client/impl/JUnitResult.java
M user/src/com/google/gwt/junit/server/JUnitHostImpl.java
M user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
M user/test/com/google/gwt/junit/GwtTestSuiteWithExpectedFailures.java
M user/test/com/google/gwt/junit/JUnitSuite.java
M user/test/com/google/gwt/junit/TestResultWithExpectedFailures.java
M user/test/com/google/gwt/junit/TestSuiteWithOrder.java
A user/test/com/google/gwt/junit/client/DefaultExceptionAsserter.java
A user/test/com/google/gwt/junit/client/ExceptionAsserter.java
R user/test/com/google/gwt/junit/client/ExpectedFailure.java
M user/test/com/google/gwt/junit/client/GWTTestCaseAsyncTest.java
M user/test/com/google/gwt/junit/client/GWTTestCaseSetupTearDownTest.java
A user/test/com/google/gwt/junit/client/GWTTestCaseStackTraceTest.java
M user/test/com/google/gwt/junit/client/GWTTestCaseTest.java
M user/test/com/google/gwt/junit/client/GWTTestCaseUncaughtExceptionHandlerTest.java
19 files changed, 361 insertions(+), 294 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2290
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to