Roberto Lublinerman has posted comments on this change.
Change subject: Chooses a default gwt source level to match the current
java runtime.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 83: double javaSpecLevel =
Double.parseDouble(System.getProperty("java.specification.version"));
Hashmaps: yes, at fist I was not storing the java version value in the
enum, will remove the hashmap :)
I was trying to make it future proof, i.e. if you are running under 1.8 gwt
should choose 1.7 (the best match) and for that relying in the numerical
ordering seemed appropriate. We could rely on the string ordering and avoid
all parsing, although it is only done once.
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
