Matthew Dempsky has posted comments on this change.
Change subject: Chooses a default GWT source level to match the current
java runtime.
......................................................................
Patch Set 4:
(2 comments)
Argh, apparently these comments didn't get posted when I reviewed patch set
5. Frustrating.
....................................................
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 30: /**
Nit: Blank line before the javadoc.
Line 67: if (Util.versionCompare(javaSpecLevel,
sourceLevel.stringValue) >= 0) {
I like Util.versionCompare() a lot more than the double parsing from
before. :) [Edit: Renaming to Utility is fine by me too.]
However, the "last match wins" strategy seems to assume that the
SourceLevels will be in increasing order? If so, I think that's worth
adding as a quick comment like "Static initializer for DEFAULT_SOURCE_LEVEL
depends on these being in increasing order" right before JAVA6 and JAVA7
above.
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
