Brian Slesinsky has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 5:
(1 comment)
....................................................
File user/src/com/google/gwt/user/client/ui/ResizeComposite.java
Line 25: public abstract class ResizeComposite<T extends Widget &
RequiresResize>
Looking at this example, the main advantages I see are that (a) you don't
need to define a constructor in this class to enforce its constraints, and
(b) we're restricting the type on the one-argument version of initWidget(),
so subclassing is a bit less error-prone. But this will be an internal
detail of the class that gets constructed.
But what if the subclass wants a delegate and RequiresResize at the same
time? Then we're enforcing a constraint on the delegate, not the widget.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
