Brian Slesinsky has posted comments on this change.
Change subject: Introduces generic Composite widgets.
......................................................................
Patch Set 4:
It might be possible to intercept the events and update the source after
they're generated:
class ClickSourceFixer extends ClickHandler {
ClickHandler wrapped;
Object newSource;
void onClick(Event e) {
Object oldSource = e.getSource();
e.setSource(newSource);
try {
wrapped.onClick(e);
} finally {
e.setSource(oldSource);
}
}
}
When someone calls foo.addEventHandler, the composite could wrap the
handler before passing it to the delegate.
But this isn't transparent because someone might keep a reference to the
event. To fix that we'd have to copy the event. If the composite has its
own set of event handlers then the event only has to be translated once.
Perhaps we could have a ForwardingHandlerManager that does this.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
