Daniel Kurka has posted comments on this change.

Change subject: Utility to store multiple HandlerRegistrations
......................................................................


Patch Set 1:

(3 comments)

....................................................
File user/src/com/google/web/bindery/event/shared/HandlerRegistrationCollection.java
Line 37:    * {@link HandlerRegistration}s
Done


Line 41: public static HandlerRegistrationCollection create(HandlerRegistration... handlers) {
It allows for readable code:
HandlerRegistration hr1 = ...
HandlerRegistration hr2 = ...
return HandlerRegistrationCollection.create(hr1, hr2);

instead of:
HandlerRegistration hr1 = ...
HandlerRegistration hr2 = ...
HRC hrc = new HandlerRegistrationCollection();
hrc.add(hr1);
hrc.add(hr2)
return hrc;

We could go for a var args constructor, but I don't like those.


Line 49: private LinkedList<HandlerRegistration> handlers = new LinkedList<HandlerRegistration>();
Done


--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75ccd120b78e1be47fa6a1e4f20c607c68203c31
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to