Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
user/src/com/google/web/bindery/event/shared/HandlerRegistrationCollection.java
Line 47: public static HandlerRegistrationCollection
create(HandlerRegistration... handlers) {
I think this is a good idea, only we need a slightly better implementation
to avoid potential mem leaks when someone forgets to null out the reference.
Updated my implementation to use the API, but account for the mem situation.
Line 55: private Set<HandlerRegistration> handlers = new
HashSet<HandlerRegistration>();
Done
Line 61: public void addHandlerRegistration(HandlerRegistration hr) {
trying with a static version for now
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75ccd120b78e1be47fa6a1e4f20c607c68203c31
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
