https://bugs.gpodder.org/show_bug.cgi?id=740
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[email protected] |[email protected] --- Comment #6 from Thomas Perl <[email protected]> 2009-12-28 22:24:42 GMT --- Thanks for your patches. I have had a look at them. Maybe you can fix the following issues and incorporate the feedback in an updated set of patches: * The detection code for media content and image enclosures can go directly to model.py without problems - after that, the second patch should not be needed anymore (after all, no "audio podcast" will have an image set for media content or a enclosure pointing to images) * I'm not sure if scraping images from HTML summaries is such a good idea - maybe we can leave that out for now? * The patch for the "generic" image icon is okay, but please remove the whitespace changes (style cleanups should be done separately from code cleanups) - otherwise it's ready to merge already * For the last patch, why not add an additional parameter ("filename") that is set to None by default, and when it's set to some other value caching is deactivated and the code creates the image from the file This way, we not only avoid errors (the file "audio-x-generic" exists) and also make sure that caching does not generate problems. * Maybe crop the image to a square size so that it looks better in the episode list? (i.e. cut off things, but keep aspect ratio) Additional ideas if you feel motivated (and probably after the patch): * What about an additional plug-in (like soundcloud.py) that will work on e.g. Flickr URLs so that images from a Flickr user are put into a custom feed? This way, we could support different services without relying on "scraping" the HTML of feeds HTH. If you have any questions, feel free to ask :) -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
