https://bugs.gpodder.org/show_bug.cgi?id=740
--- Comment #7 from Thibauld Nion <[email protected]> 2009-12-28 23:11:59 GMT --- > * The detection code for media content and image enclosures can go > directly to model.py without problems Cool, I did not want to be too intrusive with the first patch, but it definitely makes more sense to put the enclosure/content stuff in model.py. > * I'm not sure if scraping images from HTML summaries is such a good > idea - maybe we can leave that out for now? I don't like it either to be honest, but a lot of photo blogs (at least a lot that I'm following) don't use enclosures nor media:content and just include a photo in the post (I can't blame them, I'm doing the same when I post pictures on wordpress :S ). But it's ok to let this aside for the moment, media:content and enclosure should make it possible to handle feeds from big photo sites like flickr or 23hq, which should already be quite useful. > * The patch for the "generic" image icon is okay, but please remove > the whitespace changes (style cleanups should be done separately > from code cleanups) - otherwise it's ready to merge already ok sorry for the whitespace stuff, I just did not see it. when posting the patch, I'll try to be more prudent next time. > * For the last patch, why not add an additional parameter ("filename") > that is set to None by default, and when it's set to some other value > caching is deactivated and the code creates the image from the file > This way, we not only avoid errors (the file "audio-x-generic" exists) > and also make sure that caching does not generate problems. Seems good to me. > * Maybe crop the image to a square size so that it looks better in > the episode list? (i.e. cut off things, but keep aspect ratio) That's a matter of personal taste I guess, but I don't really like the images to be cropped in such a way. Especially the format (landscape/portait/square/...) is kind of part of the photo, and if one wants to quickly look up a photo in the episodes list, it'll definitely help if the format is kept. > * What about an additional plug-in (like soundcloud.py) that will > work on e.g. Flickr URLs so that images from a Flickr user are > put into a custom feed? This way, we could support different > services without relying on "scraping" the HTML of feeds Sounds good, except that flickr already works quite ok with those patches (because it has the media:content item). However if there's a simple way to link a flickr username to the actual rss feed this might be quite handy. Does the plugin system allows this kind of stuff ? I think I should look into it (after cleaning up the first patches). -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
