Yo Fred! On Fri, 14 Nov 2025 14:27:52 -0800 (PST) Fred Wright <[email protected]> wrote:
> > Could you be more specific? What "strnlen() fallback"? Which
> > commit?
>
> Commit 6cb4d38f removed the strlen() fallback (introduced in commit
> e9e15e6e), as well as fixing a bug introduced by commit 27610cbc (not
> mentioned in the commit message).
The commit message:
SConstruct: REmove strnlen() test, it is POSIX 2008.
gpsd requires POSIX 2008. What system do you have that does not have
that? If this is the only POSIX 2008 issue, we can retore the
strnlen() fallback.
> > For most Qt4 is long dead. scons now looks for Qt5, then Qt4. And
> > the override was still supposed to work. So please share your
> > fixes before commting.
>
> No, it now looks for Qt6, then Qt5, and doesn't allow Qt4 at all.
> Qt4 needs to be handled a bit differently, since it has QtNetwork
> rather than Qt4Network.
Oh. That's old shit. If you can get that to autodetect fine, but that
is a pretty obsolete package.
> The history is that gpsd originally only supported Qt4. When I
> determined that it could be built for Qt5 just by replacing
> 'QtNetwork' with 'Qt5Network', I added the 'qt_versioned' option to
> allow that. The reason it's called 'qt_versioned' rather than
> 'qt_version' is because it's based on the naming convention for
> 'QtNetwork', though in hindsight that was probably a poor naming
> choice.
Hard to see the future sometimes.
> My 10.9 system has both Qt4 and Qt5.8 (the last version for 10.9)
> installed. Prior to commit 875fa2da, the default blank qt_versioned
> chose Qt4, which still worked. Now, the blank qt_versioned means
> "choose Qt6 or Qt5", with no option for Qt4. And it still doesn't
> build for Qt5.8.
I'll leave that to you. Pretty much everyone else is on Qt6
> The fix I currently have adds '4' to the version list, while also
> handling the naming exception correctly. It's still a regression,
> since with both Qt5 and Qt4 installed, it prefers the non-working Qt5
> to the working Qt4. That could be fixed by changing the priority
> order, but that seems like too much of a kludge. I currently have a
> local-only patch to make Qt4 the default, to simplify testing.
Yeah, too much of a kludge.
> It might only take a modest amount of work to fix the version
> selection and/or the Qt5 build, but that's not appropriate right
> before a release. And all the Qt stuff is a big mess in general, for
> multiple reasons. My current fix is just a minimal fix to unbreak
> the Qt4 case.
Fix what you can, without taking a lot of risk. Release can wait a
bit longer. This is the sort of thing that often triggers a .1.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
[email protected] Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin
pgpLEkXLAmwxD.pgp
Description: OpenPGP digital signature
