On 2015-03-17 2:03 PM, Élie Roux wrote:
In fact my answer was to Henry, thinking about long-time contributors like him, but for new developpers, it's different.
Sorry if I didn't pick up on that. I've been thinking about this more broadly as a prelude for updating the documentation.
You're right. A possibility is also to make a rule saying that one cannot merge his own pull requests, so that someone "takes the responsibility" (although we shouldn't be too serious about it) to proofread it (not always in every detail) and merge it (or not). What do you think?
I think this is probably a good rule to have. While it can't guarantee that every change will get two sets of eyes on it (as one could always merge without looking) it will encourage that practice.
Also, note that having a separate repository is not mandatory for pull requests, they can be done inside the main repository. But we can also say that working directly on the main repository should be avoided. I'm the main culprit of this not so good practice, but I'm ready to change for a cleaner solution!
While a pull request can stay within the main repository (say merging two branches together), I was thinking specifically of the instance where someone with out push capability makes a change to the code. Even if it's on a temporary branch, without push access they can't upload their code to the repository to start the pull request. A personal fork gives them somewhere to put the new code so that they can initiate the pull request.
Once a person has push access to the main repository, I don't think it makes a bit of difference whether they push to a personal fork or a new branch within the main repository, as long as we don't push directly to develop, master, or a release branch. Having a personal fork just makes things more forgiving, as changes made to a fork's master, develop, or release branch won't affect the main repository. I know I often take advantage of this to do work directly on those branches on my computer.
✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝ Br. Samuel, OSB (R. Padraic Springuel) PAX ☧ ΧΡΙΣΤΟΣ _______________________________________________ Gregorio-users mailing list [email protected] https://mail.gna.org/listinfo/gregorio-users
