At 2024-07-29T19:28:40-0500, Dave Kemper wrote: > On Wed, Jul 24, 2024 at 2:24 PM G. Branden Robinson > > Sure enough, there were problems. I've fixed them in my working > > copy and you can expect them in my next push. > > Commit 0cc32d8b7 > (http://git.savannah.gnu.org/cgit/groff.git/commit/?id=0cc32d8b7) > seems to be the cited fix. > > I have one correction and one suggestion about this change. > > Correction: > The text "the @code{sp} and @code{br} requests" was added, but the > example uses no .br. According to the git log entry, this should say > "bp".
Thanks! Look for this in my next push. > Suggestion: > The git log entry, specifically the third and fourth items, explain > why certain .sp parameters are written as they are. At least the > latter of these items, and maybe both, are subtle points about margin > sizes worth explaining to readers (of the manual, not just of the git > log). > > (And I'm not sure the git log explanation is quite right: it says > "adjusting [the footer] 1v up the page from the bottom of the body > text" where it seems to mean "1v up the page from *half an inch below* > the bottom of the body text." As written, it sounds like the footer > overstrikes the bottom of the body text.) Okay. I'll review the text and see how I might expand and correct it. Regards, Branden
signature.asc
Description: PGP signature
