Hi Med, On 02/07/2025 11:55, [email protected] wrote:
Hi Martin,One quick comment on this one: leaf type { type uint8; mandatory true; description "High-order Type of the community. Supported values are 0 (0x00) for Transitive Two-Octet AS-Specific Extended Communities, 2 (0x02) for Transitive Four-Octet AS-Specific Extended Communities, 64 (0x40) for Non-Transitive Two-Octet AS-Specific Extended Communities and 66 (0x42) for Non-Transitive Four-Octet AS-Specific Extended Communities."; } Some restriction on the allowed values is needed here. If this is a definite list, then a range or enumeration may be appropriate.
Fixed.
Alternatively, if we think that future AS-specific values can be defined in the future, rather than having something frozen in the module itself, you may consider defining an IANA-maintained module that will be based on https://www.iana.org/assignments/bgp-extended-communities/bgp-extended-communities.xhtml#transitive and https://www.iana.org/assignments/bgp-extended-communities/bgp-extended-communities.xhtml#non-transitive filtered to include only AS-specific values. The value of this approach is that we can use these new values without having to modify an RFC :-)
Adding additional type values would require the restrictions in extended/global-admin to be adjusted as well. So a bis document would be needed either way, no?
Kind regards, Martin _______________________________________________ GROW mailing list -- [email protected] To unsubscribe send an email to [email protected]
