Hello Mike, Thank you for the review. Responses inline:
On 14 Apr 2026, at 04:03, Mike Bishop via Datatracker <[email protected]> wrote: > Section 5.4, paragraph 7 >> * The mirror client MUST verify that the hashes of each Delta and >> Snapshot File have not changed compared to previous entries seen >> for the same file type and version. If a newer Update >> Notification File contains a different hash for a specific file, >> this indicates a misconfiguration in the server and the client >> MUST reject the Update Notification File. The client can do this >> by recording the files referenced by the previous valid Update >> Notification File and comparing the overlapping entries with the >> retrieved Update Notification File. > > > As written, this could be an unbounded state commitment -- the client is > expected > to retain this information forever. I would think it's sufficient to require a > comparison to the previously-accepted Update Notification file. Thanks for spotting that. We have fixed this in: https://github.com/mxsasha/nrtmv4/commit/500f1f9736db379d015ba73b91f813d3c549036d > Section 4.3.2, paragraph 3 >> * The mirror server MUST generate a new Snapshot File between once >> per hour and once per day, if there have been changes to the IRR >> objects. > > What value does the lower bound serve? Is this intended to be read as "MUST > NOT > generate a snapshot more frequently than once per hour"? If so, what do > clients > do if they notice too-frequent updates? The purpose of the lower bound is to provide a guideline to prevent excessive resource use for snapshot creation. But, there is no incompatibility issue for the client. Therefore, we made the lower bound non-normative. Adopted in: https://github.com/mxsasha/nrtmv4/commit/79ce84d4f2989d9a68884df7ecfc1e84ef58536c > Section 4.3.2, paragraph 3 >> * The version number of the new snapshot MUST be equal to the last >> Delta File version. > > Given the last bullet, it might be worth specifying that it's the last Delta > File as of the time the server begins generating the snapshot. That is certainly clearer, adopted in: https://github.com/mxsasha/nrtmv4/commit/79ce84d4f2989d9a68884df7ecfc1e84ef58536c > All comments below are about very minor potential issues that you may choose > to > address in some way - or ignore - as you see fit. We have adopted all of these. Sasha _______________________________________________ GROW mailing list -- [email protected] To unsubscribe send an email to [email protected]
