I'm afraid it is not correct. You should not have to manually parse the protos in your application code. Also, it seems like it isn't handling errors properly. It is not correct to log the error, and then continue using the variable later.
On Saturday, September 29, 2018 at 7:24:27 AM UTC-7, omid pourhadi wrote: > > > Hi, > > I created a simple crud project based on grpc and spring.I want to know if > this is the correct way of using grpc or I'm going to end up failing when > my project starts to work ? > > https://github.com/omidp/grpc-crud > > > https://github.com/omidp/grpc-crud/blob/master/grpc-server/src/main/java/com/omid/grpc/service/PersonServiceImpl.java#L68 > > Thank you for your time to review it. > > I welcome any suggestion. > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscr...@googlegroups.com. To post to this group, send email to grpc-io@googlegroups.com. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/7f2a8936-8b64-42b9-8784-a5092af47d8f%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
