On Monday 30 April 2007 01:22, Robert Millan wrote: > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > > Here's my patch. Let me know if it's ok for commit. > > > > To include this in the official repository, you need to take care about > > the portability. [...] > > I ported it to bourne shell. It's tested and known to work with dash as > /bin/sh. I think this should address your concern. > > My new patch also arranges the logic for generating update-grub components > to make it more similar to how grub-install is handled.
Some issues are still there. You should avoid test -z. Instead, use test x$foo = x. You should avoid ! in test. Use else instead. You should avoid using which. Travese $PATH instead. Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
