On Tue, May 01, 2007 at 10:45:39PM +0200, Yoshinori K. Okuji wrote:
> On Monday 30 April 2007 01:22, Robert Millan wrote:
> > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote:
> > > On Tuesday 17 April 2007 14:49, Robert Millan wrote:
> > > > Here's my patch. Let me know if it's ok for commit.
> > >
> > > To include this in the official repository, you need to take care about
> > > the portability. [...]
> >
> > I ported it to bourne shell. It's tested and known to work with dash as
> > /bin/sh. I think this should address your concern.
> >
> > My new patch also arranges the logic for generating update-grub components
> > to make it more similar to how grub-install is handled.
>
> Some issues are still there. You should avoid test -z. Instead, use test
> x$foo
> = x.
Ok
> You should avoid ! in test. Use else instead.
Earlier when I read the portability document I was pointed to, I found:
"You may use `!' with `test', but not with `if'"
Are you sure this change is required?
> You should avoid using
> which. Travese $PATH instead.
Do you mean something like:
IFS=:
for i in $PATH ; do
grub-probe="$i/grub-probe"
if test -x $grub-probe ; then break ; fi
done
?
--
Robert Millan
My spam trap is [EMAIL PROTECTED] Note: this address is only intended
for spam harvesters. Writing to it will get you added to my black list.
_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel
