On Friday 11 May 2007 18:21, Robert Millan wrote: > On Fri, May 11, 2007 at 06:11:34PM +0200, Robert Millan wrote: > > One thing that I'm not sure about is the CLI inconsistency. Perhaps it > > shouldn't take the directory as a standalone parameter, and instead use > > --root-directory? > > Or perhaps it should do like powerpc and check that /boot/grub is a mount > point? > > # Find the partition at the right mount point. > install_device=`awk '$2 == '"\"$grubdir\""' { print $1 }' < /proc/mounts` > if test "x$install_device" = x; then > echo "$grubdir must be a mount point." > exit 1 > fi
It is a bad idea to use /proc, at least without checking the operating system. This makes the script unportable among host operating systems. Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel