On Tue, May 15, 2007 at 10:20:41PM +0200, Yoshinori K. Okuji wrote: > > > > One thing that I'm not sure about is the CLI inconsistency. Perhaps it > > shouldn't take the directory as a standalone parameter, and instead use > > --root-directory? > > Consistency is important, but it is not a must, as long as the user can > easily > guess the difference. In principle, you should respect consistency, but > should not blindly believe in it. So if you think it is reasonable to make > difference, you can. Otherwise, don't.
Ok. My last version is mostly consistent (/boot/grub path is a default, and can be overriden the same way), the difference being that it doesn't take any non-flag argument. But I think this difference is reasonable, specially considering that i386/pc/grub-install and powerpc/grub-install already differ on this part. > > Not really sure about these. Seems ugly, but biosdisk.h has the > > grub_util_biosdisk_get_grub_dev definition, which is not really > > i386/pc-specific. Also, note that powerpc needs them as well if we > > want update-grub to work there (haven't submitted this part, because it > > grub-probe on powerpc has other issues that I cannot debug). > > If it is not specific to i386-pc, it should be moved to somewhere else. Will do. Thanks, -- Robert Millan My spam trap is [EMAIL PROTECTED] Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list. _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
