Thomas Schwinge <[EMAIL PROTECTED]> writes: > Hello! > > On Sun, Jun 10, 2007 at 09:57:44AM +0200, Marco Gerards wrote: >> Bean <[EMAIL PROTECTED]> writes: >> > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: >> >> The normal procedure for patches is to make them consistent with the >> >> GCS (GNU Coding Standards), include a changelog. That way it is >> >> easier to review the patch and to include it in GRUB 2. >> >> The GNU Coding Standards: >> http://www.gnu.org/prep/standards/standards.html >> >> The specific part on ChangeLog entries: >> http://www.gnu.org/prep/standards/standards.html#Change-Logs >> >> The biggest part is on indentation, etc. > > Sorry, but that is also the part which the upstream committers (e.g. you, > or me, or some more others) can trivially fix if you don't like it the > way the first-time contributor has done. That's my idea of this eternal > ``your-formatting-only-does-stop-us-from-committing-your-patch'' thing. > And that is also what I would expect if I were a first-time contributor. > Otherwise I might decide to spend my time elsewhere.
The problem is, as you may know, that we have very little time to clean up all the patches. But I am certainly willing to help people wherever possible with these kind of tasks. Besides that, for my feeling the coding style is part of the job. But if you do have the time, please help us out! -- Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
