On Wed, Mar 28, 2018 at 04:50:28PM +0200, Hans de Goede wrote: > If we're running with a hidden menu we may never need text mode, so do not > change the video-mode to text until we actually need it. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > grub-core/term/efi/console.c | 72 +++++++++++++++++++++++------------- > 1 file changed, 47 insertions(+), 25 deletions(-) > > diff --git a/grub-core/term/efi/console.c b/grub-core/term/efi/console.c > index 02f64ea74..d9fd7cf48 100644 > --- a/grub-core/term/efi/console.c > +++ b/grub-core/term/efi/console.c > @@ -24,6 +24,11 @@ > #include <grub/efi/api.h> > #include <grub/efi/console.h> > > +static grub_err_t grub_prepare_for_text_output(struct grub_term_output > *term);
Please drop this forward declaration and put the function definition before the callers. > +static int text_mode_available = -1; Could you use bool type here? If yes please define grub_bool_t as stdbool.h does (grub/bool.h?) and replace its usage in grub-core/term/tparm.c as separate patch. If not bool please use enum here. > +static int text_colorstate = -1; Ditto. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel