On Mon, Nov 24, 2025 at 12:49:06PM +0100, Daniel Kiper wrote: > Adding Alec, Peter, Steve, Marta, Leo, Luca, Mate and Julian. Please > keep these folks in the loop for this patch set. > > On Mon, Nov 24, 2025 at 11:39:47AM +0200, Radoslav Kolev via Grub-devel wrote: > > This can be especially helpful, as the Fedora version of the blscfg > > actually made use of arguments. In case of old configs/scripts the > > new implementation will now error out instead of falling back to > > defaults silently. > > > > Signed-off-by: Radoslav Kolev <[email protected]> > > --- > > grub-core/commands/blsuki.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/grub-core/commands/blsuki.c b/grub-core/commands/blsuki.c > > index 0fd4458e6..09f6bb4ef 100644 > > --- a/grub-core/commands/blsuki.c > > +++ b/grub-core/commands/blsuki.c > > @@ -1454,9 +1454,11 @@ blsuki_cmd (grub_extcmd_context_t ctxt, enum > > blsuki_cmd_type cmd_type) > > } > > > > static grub_err_t > > -grub_cmd_blscfg (grub_extcmd_context_t ctxt, int argc __attribute__ > > ((unused)), > > +grub_cmd_blscfg (grub_extcmd_context_t ctxt, int argc, > > char **args __attribute__ ((unused))) > > { > > + if (argc != 0) > > + return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("no arguments expected, > > see --help")); > > return blsuki_cmd (ctxt, BLSUKI_BLS_CMD); > > } > > > > @@ -1464,9 +1466,11 @@ static grub_extcmd_t bls_cmd; > > > > #ifdef GRUB_MACHINE_EFI > > static grub_err_t > > -grub_cmd_uki (grub_extcmd_context_t ctxt, int argc __attribute__ > > ((unused)), > > +grub_cmd_uki (grub_extcmd_context_t ctxt, int argc, > > char **args __attribute__ ((unused))) > > { > > + if (argc != 0) > > + return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("no arguments expected, > > see --help")); > > return blsuki_cmd (ctxt, BLSUKI_UKI_CMD); > > } > > I am not convinced we have to have this. I want to hear other folks > opinion here. If you convince me to have this behavior for these > commands I think this exception have to be documented in the GRUB > documentation.
It looks nobody strongly objects. So, I am OK with behavior change. Though grub_error() message is confusing for me because the commands get arguments. So, I think it should be better phrased. Please do not forget to update patch #2 too. Daniel _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
