Op 17-sep-04 om 23:55 heeft Haxe het volgende geschreven:
On Thursday 16 September 2004 22:11, Jeroen Asselman wrote:...That is why I'd like to propose another implementation. Instead of queueing per client, which is what PARQ actually tries to achive, lets queue per file.What do you think?
For the following reasons, I don't think that this would be a good idea
1. It would violate the already written PARQ specs, which explicitly claim the exact opposite.
And this includes points 1-4:
No, I won't break the PARQ specs. This is just an idea which I think could be the successor of the current version.
No, it won't break older clients. Because we can determine by the queuing version if it can be done, even if we don't it won't break older gtk-gnutella versions. GTK-Gnutella does not rely on the PARQ ID but it can make use of it. What I propose could be made transparant and nobody would notice
5. Implementing a completely new strategy takes time and effort and will, as every new software does, introduce new bugs. Today there are more important things to do in gtkg.
I don't find this an argument myself. Everyone has its own priority. I never said I would make this change today.
In my opinion, instead of implementing a new queuing strategy, it would be completely sufficient to fix the little issues with the existing implementation. Which are: - After every received request (not only the first), test if the requested file exists before queuing. If it doesn't exist, send a 404 instead of a 503.
In which case we break the specs, and you just told me we shouldn't break previous gtk-gnutella versions.
- Finally fix that old race condition that leads to incorrect handling/queuing of incoming requests (e.g. too many simultaneous uploads to one host)
Yeah, I should look into that. But if you have time to spare...
When those two things are done, it would really be good enough and work very well.
In my opinion it won't work well enough. But that is of course just me, awaiting further comments. If I decide to implement it I will make it optional anyway.
- Jeroen
------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
