Bill Pringlemeir wrote:
> qrt_build_query_target() has the following lines...

>         if (is_leaf) {
>             /* Leaf node */
>             if (rt == NULL)             /* No QRT yet */
>                 continue;               /* Don't send anything */

This is actually wrong. Leaves that don't support query routing
should always get the query.

> I think the last two translate to,
 
>             if(!(ttl == 1))      /* (ttl != 1) */ 
>                 continue;
>             if(ttl == 0)         /* TTL must be one here? */
>                 continue;

> Maybe I am up too late ;-).  I guess the second test never needs to be
> made.  However, it doesn't look like we would forward query requests
> with a TTL greater than one?  Is this impossible to have a ttl greater
> than one?

The second check is indeed unnecessary. Queries with a TTL greater
than one are handled by the calling function. It's a bit hard to
follow the code though albeit the routing scheme is not really that
complex.

-- 
Christian

Attachment: pgpAApv8FDErQ.pgp
Description: PGP signature

Reply via email to