>From: Christian Biere <[EMAIL PROTECTED]> >Date: Fri, 17 Nov 2006 10:00:55 +0100 > >Lloyd Bryant wrote: > >I've integrated your patch now. However, instead of sorting the list, I >decided >to sort file_table[]. Maybe this fixes the performance issue you've >noticed. I >didn't notice a significant difference but it shouldn't be slower in any >case. >I did this mainly because request_sha1() can cause to remove the file again >but >a NULL pointer in shared_files was handled elsewhere whereas holes in >file_table[] are already expected. Removing a node from a GSList is a bit >awkward albeit not really difficult but I consider sorting the table >simpler >and clearer. >
Just tested the SVN version. The sort is ASCENDING mtime (most recent last). src/core/share.c:1164 return CMP(t1, t2); should be "return CMP(t2, t1);" for descending (most recent first). Lloyd Bryant ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Gtk-gnutella-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
