Hi Maxime, On Oct 24, 2010, at 22:38, Maxime Henrion wrote:
> Hello all, > > > Yet another boring patch to update signal handlers to the new way of > doing things, this time for the MenuItem and Item objects :-). There > is, however, something of interest in this patch. > > I was surprised to see that the "onToggle" and "afterToggle" signal > handlers were actually bound to the signal name "toggled". Checking > the > GTK+ API documentation, it appears the correct signal name is really > "toggle", without the final 'd' character. I suspect this code never > worked before, but that noone was unlucky enough to actually hit it. > Therefore, I corrected the signal name in the new signal handler as > well > as in the deprecated signal handlers. > Yes, quite possible that this code was always broken! > Finally, another question comes to mind: why is the "activate" signal > bound by the "activateLeaf" signal handler? Should I take advantage > of > this patch to rename it to just "activate", or "menuItemActivate" if > there are namespace conflicts? > I might have chosen that name to distinguish it from other occurrences of "activate". Since we now use prefixes, you should use "menuItemActivate". Thanks for fixing these, Axel > Cheers, > Maxime > < > menuitem > .patch > > > ------------------------------------------------------------------------------ > Nokia and AT&T present the 2010 Calling All Innovators-North America > contest > Create new apps & games for the Nokia N8 for consumers in U.S. and > Canada > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in > marketing > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi > Store > http://p.sf.net/sfu/nokia-dev2dev_______________________________________________ > Gtk2hs-devel mailing list > Gtk2hs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Gtk2hs-devel mailing list Gtk2hs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel
