Hi,

Neil Jerram <[EMAIL PROTECTED]> writes:

> Basically yes, but two thoughts:
>
> - Can I just take a couple more days to review the srcprops changes in
>   detail?  It's important for my debugging work, and I recall having
>   some concern when Han-Wen implemented this...  Looking at the diffs
>   quickly again now, I can't see any reason for that concern, but I'd
>   like to be sure.
>
> - Although I agree in principle that all those macros shouldn't be in
>   srcprop.h, do we really need to make that change now?  I think we can
>   just apply Han-Wen's changes to the macros in srcprop.h, without
>   moving them to srcprop.c.

Are you OK to apply the patch?

Thanks,
Ludovic.



Reply via email to