Jonas Hahnfeld via "Developers list for Guile, the GNU extensibility library" <guile-devel@gnu.org> writes: > On Tue, 2023-11-28 at 22:04 +0100, Jonas Hahnfeld wrote: >> On Sun, 2023-10-29 at 22:34 +0100, Jonas Hahnfeld wrote: >> > I would like to propose a different approach: It turns out to be >> > possible to just define scm_t_inum as intptr_t, while leaving GMP >> > interfaces alone (be that mini-gmp or a full GMP). Instead, the >> > mismatch in type widths can be handled during the conversion to mpz. >> > For a practical implementation, see the fourth patch attached to this >> > message. >> > >> > Afterwards, the fifth patch takes care of the hashes, which are >> > expected to have the same width as pointers. This is required because >> > (at least) hashes of symbols are stored into the bytecode. Taken >> > together, this seems to enable enough functionality to run LilyPond >> > with Guile 3 on Windows. >> > >> > What do you and others think of this approach, would this be "more" >> > acceptable to land in main? >> >> Ping, any comments on this approach? I built binaries for LilyPond >> 2.25.10 using these patches applied on top of Guile 3.0.9 and the >> result seems to work fine on Windows. > > Another ping; meanwhile we switched to building the official binaries > of LilyPond with Guile 3.0 starting from version 2.25.11,
That’s awesome! > but it would be really great to get rid of our downstream patches... I don’t know enough about our GMP use and cross-compilation, so I cannot really comment on your patch. I can get it merged once it’s reviewed, so if anyone here can review: if this passes review, upstreaming won’t be the bottleneck. Best wishes, Arne -- Unpolitisch sein heißt politisch sein, ohne es zu merken. draketo.de
signature.asc
Description: PGP signature