Mark H Weaver <[email protected]> skribis:
> Ricardo Wurmus <[email protected]> writes:
[...]
>> There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also
>> released under non-free terms, but they are enclosed in #ifdef
>> statements and the make flags we pass disable these functions at build
>> time.
>
> This is not sufficient. We will need to completely remove the non-free
> functions from the source code using a snippet. We cannot use a patch
> because the patch would contain the non-free code.
Indeed (I thought Kernel.{cpp,h} were the files being removed.)
I guess there are two ways to address this: have a snippet that reads
these two files line by line (with ‘read-line’ from (ice-9 rdelim)) and
dismisses files within the #ifdef.
If that turns out to be impractical, for instance because there are
nested #ifdefs or computed conditionals, then we’ll have to host a
cleaned up source tarball or repo somewhere.
Ricardo: could you look into it?
Thanks,
Ludo’.