Ludovic Courtès <[email protected]> writes: > 宋文武 <[email protected]> skribis: > >> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable. > > [...] > >> +(define-public adwaita-icon-theme >> + (package (inherit gnome-icon-theme) >> + (name "adwaita-icon-theme") >> + (version "3.16.0") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "mirror://gnome/sources/" name "/" >> + (version-major+minor version) "/" >> + name "-" version ".tar.xz")) >> + (sha256 >> + (base32 >> + "1cbfdypxfg74krqrklh4za64jhvskbp206l14fs739cw14xsvj53")))) >> + (native-inputs >> + ;; XXX: gtk-encode-symbolic-svg lacks SVG support. >> + (alist-delete "gtk+" (package-native-inputs gnome-icon-theme))))) > > Why is this ‘alist-delete’ needed? Perhaps you just need to expound the > comment. With 'gtk+', it will: 1. use gtk-update-icon-cache to build a index-theme.cache (ok) 2. use gtk-encode-symbolic-svg to convert symbolic SVGs to PNGs (failed)
The reason is gtk-encode-symbolic-svg lacks librsvg support for gdk-pixbuf, maybe we should wrap it with GDK_PIXBUF_MODULE_FILE. > > Also, I think specific ‘synopsis’ and ‘description’ need to be > provided. The gnome-icon-theme was renamed to adwaita-icon-theme after 3.12, So, I think the 'synopsis' and 'description' applied too. > > WDYT? I plan to fix the 'gtk-encode-symbolic-svg' and remove the 'alist-delete'. Thanks for review! > > Thanks, > Ludo’.
