Ludovic Courtès <[email protected]> writes: >> From 19a28042f3839ea23aa13f4973172ca46cfde5f0 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus <[email protected]> >> Date: Mon, 9 Nov 2015 14:46:56 +0100 >> Subject: [PATCH 1/2] gnu: Add cereal. >> >> * gnu/packages/serialization.scm: New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > > [...] > >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (doc (string-append out "/share/cereal/docs")) >> + (include (string-append out "/include/cereal"))) >> + (mkdir-p doc) >> + (mkdir-p include) >> + (copy-recursively "include/cereal" include) >> + (copy-recursively "doc/html" doc)) > > Maybe add a comment about why “make install” isn’t enough.
Okay. I added a comment explaining that there is no “install” target. > Otherwise LGTM. > >> From 1f8739407dd3f9715005d55befabf894fa98ee10 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus <[email protected]> >> Date: Tue, 10 Nov 2015 15:41:04 +0100 >> Subject: [PATCH 2/2] gnu: Add sparsehash. >> >> * gnu/packages/crypto.scm (sparsehash): New variable. > > LGTM. Thank you. I’ll push both in a moment. ~~ Ricardo
