宋文武 <iyzs...@gmail.com> skribis: > * gnu/packages/samba.scm (talloc): Update to 2.1.5. > [arguments]: Use 'modify-phases' syntax.
It uses ‘modify-phases’ and also modifies stuff in ‘wscript’, which should be mentioned here. It would be ideal if you could make one patch that switches to ‘modify-phases’, and the next one that upgrades and adds the ‘wscript’ change. > + ;; test_magic_differs.sh is a broken script, skip the test. Could you mention what makes it “broken”? :-) Otherwise LGTM. Besides, I wonder if we should change it to ‘waf-build-system’. Thanks, Ludo’.