l...@gnu.org (Ludovic Courtès) writes: > 宋文武 <iyzs...@gmail.com> skribis: > >> * gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs. >> [arguments]: Use 'modify-phases' syntax. > > Please mention the arguments removed (#:modules and #:imported-modules) > and the phases removed. > > Otherwise LGTM. Done, thanks for the review!
> Besides, I wonder if we should change it to ‘waf-build-system’. All things from samba projects (tevent, ldb, etc.) use a custom configure script to run its own “buildtools/bin/waf”. And waf-build-system expect “waf” and “wscript” in the same toplevel folder, so it won’t work.
