Thanks for your feedback Alex.

I have seen some other packages including multiple licenses in the list of
licenses,
so I took that approach.

I also took the liberty of taking your description, which seems to also be
coming directly from the jq website.

While digging into the valgrind issue, I found out that documentation is
currently not being generated;
after looking at what was required for this to work, I worked things out up
to the ruby-sass gem; I might finish
it if I have more time in the near future, but for now;

... jq, attempt two.

~Jelle

2016-03-26 20:13 GMT+01:00 Alex Griffin <a...@ajgrf.com>:

> Heh, I've had this packaged for ages (along with some others) and I've
> put off submitting because I don't have a good workflow yet for
> git+email. I should probably do something about that. Anyway, your
> oniguruma package looks good to me. Here's a few notes about jq:
>
> You listed jq's license at cc-by3.0, but that's only for the docs. Most
> of the jq code is under the x11 license, except a few files which were
> taken from other projects. I don't know how to specify multiple licenses
> - maybe someone more experienced with Guix can chime in?
>
> Your source URL is not stable (the hash will change at any time because
> it's autogenerated by Github and not guaranteed to be identical). I
> would use
> https://github.com/stedolan/jq/releases/download/jq-1.5/jq-1.5.tar.gz
> instead.
>
> You should add valgrind as a dependency so that the test suite can run.
>
> Finally, your description is a bit sparse. Here's what I wrote:
>
>     jq is like sed for JSON data – you can use it to slice and filter
>     and map and transform structured data with the same ease that sed,
>     awk, grep and friends let you play with text.
>
>     It is written in portable C, and it has zero runtime dependencies.
>
>     jq can mangle the data format that you have into the one that you
>     want with very little effort, and the program to do so is often
>     shorter and simpler than you’d expect.
>
> Hope that helps!
> --
> Alex Griffin
>
>
> On Sat, Mar 26, 2016, at 12:41 PM, Jelle Licht wrote:
> > ... and the actual package I wanted to use on guix!
> > Email had 1 attachment:
>
>
> >  * 0002-gnu-Add-jq.patch
> >   3k (text/x-patch)
>
>
From 991ccfdb49c9f18e35e6b99af9052f64a6464b09 Mon Sep 17 00:00:00 2001
From: Jelle Licht <jli...@fsfe.org>
Date: Sat, 26 Mar 2016 22:49:42 +0100
Subject: [PATCH 2/2] gnu: Add jq

* gnu/packages/web.scm: (jq): New variable
---
 gnu/packages/web.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 516e623..c7392c6 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayi...@gmail.com>
 ;;; Copyright © 2015, 2016 Eric Bavier <bav...@member.fsf.org>
 ;;; Copyright © 2015 Eric Dvorsak <e...@dvorsak.fr>
+;;; Copyright © 2016 Jelle Licht <jli...@fsfe.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -52,10 +53,12 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages valgrind)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages texinfo)
+  #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages statistics))
 
@@ -3109,3 +3112,33 @@ callback or connection interfaces.")
      "Gumbo is an implementation of the HTML5 parsing algorithm implemented as
 a pure C99 library.")
     (license l:asl2.0)))
+
+(define-public jq
+  (package
+    (name "jq")
+    (version "1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/stedolan/"; name
+                                  "/releases/download/" name "-" version
+                                  "/" name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0g29kyz4ykasdcrb0zmbrp2jqs9kv1wz9swx849i2d1ncknbzln4"))))
+    (inputs
+     `(("oniguruma" ,oniguruma)))
+    (native-inputs
+     `(;; TODO fix gems to generate documentation
+       ;;("ruby" ,ruby)
+       ;;("bundler" ,bundler)
+       ("valgrind" ,valgrind)))
+    (build-system gnu-build-system)
+    (home-page "http://stedolan.github.io/jq/";)
+    (synopsis "Command-line JSON processor")
+    (description "jq is like sed for JSON data – you can use it to slice and
+filter and map and transform structured data with the same ease that sed, awk,
+grep and friends let you play with text.  It is written in portable C, and it
+has zero runtime dependencies.  jq can mangle the data format that you have
+into the one that you want with very little effort, and the program to do so
+is often shorter and simpler than you’d expect.")
+    (license (list l:expat l:cc-by3.0))))
-- 
2.7.3

Reply via email to