On Tue, May 31, 2016 at 05:44:00PM -0400, Leo Famulari wrote: > On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote: > > * gnu/packages/check.scm (googletest): New variable. > > Awesome, thanks for this patch! > > > + (build-system cmake-build-system) > > I noticed in the README.md that upstream suggests use of GNU Make unless > building from a Git checkout. Did you try that? > > > + (native-inputs > > + `(("python-2" ,python-2))) > > The README also suggests that this is only necessary for building from > Git, although it's worth finding out what they mean by "re-generating > certain source files from templates". We prefer to re-build "generated" > source files since they are not really "source files" in many cases. > > > + (replace 'install > > + (lambda _ > > + (let ((out (assoc-ref %outputs "out"))) > > + (and > > + (mkdir-p (string-append out "/lib")) > > + (mkdir-p (string-append out "/include")) > > + (zero? > > + (system* "cp" "-r" > > + "../googletest-release-1.7.0/include" > > + out)) > > + (zero? (system* "cp" "libgtest.a" > > "libgtest_main.a" > > + (string-append out > > "/lib")))))))))) > > I think these uses of (system*) could be replaced by (copy-recursively) > and (install-file), respectively. >
I haven't tried building this package yet (and -> you can probably switch this for a (begin googletest-release-1.7.0 -> (string-append "../google-release-" version "/include") (zero? (system* "cp" "libgtest.a" "libgtest_main.a" won't this just copy libgtest.a to libgtest_main.a ? -- Efraim Flashner <efr...@flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature