Alex Kost <alez...@gmail.com> skribis: > Ricardo Wurmus (2016-06-29 08:45 +0300) wrote: > >> Hi Guix, >> >> I think we need to rename the “emms” package to “emacs-emms”. (This is what >> the first patch does.) Currently, the emacs-build-system will only add to >> the >> Emacs “load-path” the “site-lisp” directories of packages that start with >> “emacs-”. I think it may be necessary to relax this requirement for cases in >> which a non-Emacs package provides an Emacs mode. > > I agree! I also think this check for "emacs-" is not needed. > >> In the case of “emms”, >> however, I think renaming it is justified. > > I agree, but note that there was a discussion about renaming all emacs > packages (geiser, magit, etc.) and making alisases for the old names: > <http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>
A year later, it still looks like a good idea. :-) Damn it, we should do something about it. >> The second patch adds an EMMS player. The byte-compilation phase only >> succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp >> files provides by that package. >> >> Ricardo Wurmus (2): >> gnu: emms: Rename package to "emacs-emms". >> gnu: Add emacs-emms-player-mpv. > > Both patches look good to me, but I would wait for other comments about > renaming as it is not very backward compatible :-) A mass rename would cause users a lot of pain, but a single package is OK, IMO. (Don’t tell me you want to do a mass rename at a one rename/week rate! ;-)) Thoughts? Ludo’.