Hi David, On Fri, 7 Oct 2016 10:19:42 +0200 David Craven <da...@craven.ch> wrote: > > Ughh... are we sure we want to do that? I don't think a > > regular user would know what to put there. If the U-Boot > > build is from a clean slate it's not like there are stray files > > lying around or anything - we can just copy them all if we > > want. > > I thought about this patch and I think we should add it. The regex > solution results in a lot of garbage inside the output directory. > Regular users don't compile u-boot, and anyone with the skills to port > guixsd to a new board will know what to put. It also serves as > documentation, from reading the package definition I can tell what the > relevant files are without examining the output directory (which is > full of garbage - so I have to google it anyway).
Yeah, if there are a lot of garbage files I also think that it's okay to do it like you propose. (It's just something that we have been struggling with in the ARM world - people think their board is the only one and then you have some custom configuration which only works for their board for no good reason. In this case the U-Boot binaries (contents) are rightfully board-specific. But there's no good reason that the names and splitting-up-into-files are (or the installation process - it's 2016, a computer should automate the installation). I'll mention it upstream) I wonder how U-Boot itself finds out the target names - but that's for a future patch. (I think one could examine ALL-y to find out) So I agree. LTGM!