Hi Danny, Danny Milosavljevic <dan...@scratchpost.org> skribis:
> On Fri, 3 Feb 2017 18:45:22 +0200 > Efraim Flashner <efr...@flashner.co.il> wrote: > >> On Wed, Feb 01, 2017 at 10:51:32AM +0100, Danny Milosavljevic wrote: >> > ;; files left with the --keep-failed flag to guix build. >> > (patches (search-patches >> > "ldc-1.1.0-disable-dmd-tests.patch"))))))))) >> > >> > -(define-public ldc-beta ldc-1.1.0-beta6) >> > - > >> Without having built it to test it out, I would replace this part with >> either having it superceded by ldc-1.1.0, or have ldc-beta point to >> ldc-1.1.0, so no one who relies on it finds it broken. > > Ehhh. The variable "ldc-beta" would have existed for 5 days and was in no > Guix release - not sure anyone saw it. > > But we can do the latter so that people could rely on ldc-beta being the > newest non-release ldc (if we ever packaged another ldc beta release or even > git commit), kinda like guix-devel (corresponding to ldc-beta) vs. guix > (corresponding to ldc). Sure. I agree. Both patches look good to me, I think you can go ahead! Thank you, Ludo’.