Hello Pierre,

Pierre Neidhardt <m...@ambrevar.xyz> skribis:

> Find the last revision attached.  I've taken all comments into
> consideration and I'm quite happy with the result.

Neat!  I like it too, I’d say we can go frmo here.

> I've found a much better advanced example: libgit2.
> The only thing is... it does not pass the tests.

Heh.  :-)

> In guix, libgit2 uses an archive upstream.  I've changed the package to
> check out the git repository.  Only then the test fail:
>
> starting phase `check'
> Loaded 341 suites: 
> Started
>
> apply::fromdiff...................
> apply::fromfile..........................................
> attr::file....
> attr::flags...
> attr::ignoreF
>
>   1) Failure:
> attr::ignore::honor_temporary_rules 
> [/tmp/guix-build-my-libgit2-0.26.6-1.e98d0a3.drv-0/my-libgit2-0.26.6-1.e98d0a3-checkout/tests/clar_libgit2.c:47]
>   Expression is not true: (fd = p_open(path, flags, mode)) >= 0

Could it be because the file it tries to open here is read-only?

Usually files resulting from a checkout are read-only, so perhaps you
need to make a bunch of files writable before the ‘check’ phase.  For a
start you could do:

  (for-each make-file-writable (find-files "tests"))

Once you’ve sorted that out I’m happy to publish if there are no
objections!

Thanks,
Ludo’.

Reply via email to